Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34603 )
Change subject: mainboard/asus: Add ASUS H110M-E/M.2 mainboard
......................................................................
Patch Set 47:
(2 comments)
Isn't it high time to test this change already? :D
https://review.coreboot.org/c/coreboot/+/34603/46//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34603/46//COMMIT_MSG@9
PS46, Line 9: This port is based on the Asrock H110M
Could it be a variant?
No, as the variants are under a mainboard vendor/model. In this case it's asus vs asrock, so not a good idea.
Plus, the thing is untested...
https://review.coreboot.org/c/coreboot/+/34603/47//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34603/47//COMMIT_MSG@9
PS47, Line 9: a variant of
Please undo the commit message change
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34603
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id8fa41ecccaa8dba8dc2158ce62d328c7928e05c
Gerrit-Change-Number: 34603
Gerrit-PatchSet: 47
Gerrit-Owner: Pavel Sayekat
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maxim Polyakov
m.poliakov@yahoo.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Pavel Sayekat
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 30 Aug 2019 01:05:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment