Attention is currently required from: Bill XIE, Jonathon Hall, Jérémy Compostella.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78906?usp=email )
Change subject: drivers/pc80/rtc/option.c: Reset only checked CMOS range during resume ......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS4:
Then we could restore the checked range only during s3 resume, while restore the whole CMOS after 14 […]
Sorry, I don't see how this makes things better. It adds complexity and at the same time doesn't maintain the original behavior either. I justed wanted to create awareness of what we are changing.
Let's just back off to the problem statement. There are cases like GM45 where we want to do things differently. And we have other cases (of data outside the checksummed range) where we don't know exactly what should be done. Any of them may be affected by extending the clearing to the second bank.
I think it's ok to change these unknown cases. We are already in the middle of it anyway: Even with patchset #6, it's still not what we had before extending the CMOS clearing to bank 1. So I would prefer patchset #5.
Also an alternative, but I think this would be overkill, is to make it board-specific; e.g. add a Kconfig that controls the behavior.