Máté Kukri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43133 )
Change subject: soc/intel/baytrail: Add native refcode replacement ......................................................................
Patch Set 15:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43133/1/src/soc/intel/baytrail/incl... File src/soc/intel/baytrail/include/soc/modphy.h:
https://review.coreboot.org/c/coreboot/+/43133/1/src/soc/intel/baytrail/incl... PS1, Line 566: #define BAYTRAIL_MODPHY_REVB_OFFSET 0
I'd split the very large array in smaller arrays instead
Done
https://review.coreboot.org/c/coreboot/+/43133/4/src/soc/intel/baytrail/refc... File src/soc/intel/baytrail/refcode_native.c:
https://review.coreboot.org/c/coreboot/+/43133/4/src/soc/intel/baytrail/refc... PS4, Line 140: |
&
Done
https://review.coreboot.org/c/coreboot/+/43133/4/src/soc/intel/baytrail/refc... PS4, Line 147: |
&
Done
https://review.coreboot.org/c/coreboot/+/43133/10/src/soc/intel/baytrail/ref... File src/soc/intel/baytrail/refcode_native.c:
https://review.coreboot.org/c/coreboot/+/43133/10/src/soc/intel/baytrail/ref... PS10, Line 118: printk(BIOS_DEBUG, "ModPHY init entry\n");
It’d be great if you also added timestamps for running the ref code.
I am not sure how those work in coreboot.