build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31215 )
Change subject: WIP: riscv: Implement FIT for RISC-V ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/#/c/31215/1/src/arch/riscv/fit_payload.c File src/arch/riscv/fit_payload.c:
https://review.coreboot.org/#/c/31215/1/src/arch/riscv/fit_payload.c@104 PS1, Line 104: /* Update kernel size from image header, if possible */ code indent should use tabs where possible
https://review.coreboot.org/#/c/31215/1/src/arch/riscv/fit_payload.c@106 PS1, Line 106: printk(BIOS_DEBUG, "FIT: Using kernel size of 0x%zx bytes\n", code indent should use tabs where possible
https://review.coreboot.org/#/c/31215/1/src/arch/riscv/fit_payload.c@106 PS1, Line 106: printk(BIOS_DEBUG, "FIT: Using kernel size of 0x%zx bytes\n", please, no spaces at the start of a line
https://review.coreboot.org/#/c/31215/1/src/arch/riscv/fit_payload.c@107 PS1, Line 107: kernel->size); code indent should use tabs where possible
https://review.coreboot.org/#/c/31215/1/src/arch/riscv/fit_payload.c@107 PS1, Line 107: kernel->size); please, no spaces at the start of a line