Attention is currently required from: Zheng Bao, Fred Reitberger.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66853 )
Change subject: amdfwtool:combo: Move the filling of field "lookup" into function
......................................................................
Patch Set 9:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/66853/comment/ae88640a_42275fee
PS8, Line 565: /* caller is responsible for lookup mode */
if this always sets lookup, then this comment is probably wrong now
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66853
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53051349923dce40f4fc3f747ab41a93a3798823
Gerrit-Change-Number: 66853
Gerrit-PatchSet: 9
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Tue, 28 Feb 2023 03:35:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-MessageType: comment