Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46962 )
Change subject: mb/google/hatch/jinlon: Describe the privacy_gpio ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46962/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/jinlon/gpio.c:
https://review.coreboot.org/c/coreboot/+/46962/2/src/mainboard/google/hatch/... PS2, Line 22: PAD_CFG_GPI Then shouldn't this be `PAD_CFG_GPI_INT(GPP_D4, NONE, PLTRST, EDGE_BOTH)` ? or does the kernel reconfigure the pad?
https://review.coreboot.org/c/coreboot/+/46962/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/jinlon/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46962/2/src/mainboard/google/hatch/... PS2, Line 86: ACPI_GPIO_INPUT_ACTIVE_LOW
I though that too. but then I had a nice conversation with Andy Shevchenko. […]
Hm, I see, that's odd.