Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40247 )
Change subject: soc/amd/picasso/i2c: don't initialize I2C4 as master and refactor code
......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40247/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40247/1//COMMIT_MSG@14
PS1, Line 14: addressed
addresses?
Done
https://review.coreboot.org/c/coreboot/+/40247/1/src/soc/amd/picasso/i2c.c
File src/soc/amd/picasso/i2c.c:
https://review.coreboot.org/c/coreboot/+/40247/1/src/soc/amd/picasso/i2c.c@3...
PS1, Line 30: "ARRAY_SIZE(i2c_bus_address) must equal I2C_DEVICE_COUNT");
Sure, but why?
Done
https://review.coreboot.org/c/coreboot/+/40247/2/src/soc/amd/picasso/i2c.c
File src/soc/amd/picasso/i2c.c:
https://review.coreboot.org/c/coreboot/+/40247/2/src/soc/amd/picasso/i2c.c@2...
PS2, Line 23: APU_I2C0_BASE
oh, didn't know that; I do wonder though what the second patch i squashed into this was for then. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40247
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I397b074ef9c14bf6a4f6680696582f5173a5d0d3
Gerrit-Change-Number: 40247
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Magf -
magf@bitland.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 15 Apr 2020 00:30:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment