23 Nov
2019
23 Nov
'19
2:19 p.m.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36976 )
Change subject: vendorcode/amd/pi/Makefile.inc: remove -fno-zero-initialized-in-bss ......................................................................
Patch Set 2:
POSTCAR_STAGE=y => CAR_GLOBAL_MIGRATION=n => ENV_STAGE_HAS_BSS_SECTION=1 (for romstage)
=> MAYBE_STATIC_BSS becomes 'static'
But, with -no-zero-initialized-bss, zero-initialized static variables are .data, not .bss. And romstage .data is currently forbidden.
--
To view, visit https://review.coreboot.org/c/coreboot/+/36976
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I088ac824f9b66387843ae5810fd2c75a8b16d9db
Gerrit-Change-Number: 36976
Gerrit-PatchSet: 2
Gerrit-Owner: Krystian Hebel krystian.hebel@3mdeb.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Krystian Hebel krystian.hebel@3mdeb.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 23 Nov 2019 17:19:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment