Attention is currently required from: Johnny Lin, Ed Sharma, Paul Menzel, Martin Roth.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68637 )
Change subject: commonlib/fsp_relocate: Fix Coverity Issues
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68637/comment/c3771476_7a998996
PS3, Line 10: reported issues. This change attempts to fix the static
s/attempts to fix/fixes/
https://review.coreboot.org/c/coreboot/+/68637/comment/fa673345_78bb93bc
PS3, Line 18: on my own to test my changes against coverity tests.
The above paragraph is not needed as commit message. You could put them as gerrit comment. In addition, it would help if you copy & paste the coverity message next to each change as gerrit comment.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68637
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I635c62929e8be9a474a91a62c29c3b5ee9b0ee64
Gerrit-Change-Number: 68637
Gerrit-PatchSet: 3
Gerrit-Owner: Ed Sharma
aeddiesharma@fb.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Ed Sharma
aeddiesharma@fb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Wed, 09 Nov 2022 18:21:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment