Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/51066 )
Change subject: sb/intel/ibexpeak: Add all PCI IDs for LPC ......................................................................
sb/intel/ibexpeak: Add all PCI IDs for LPC
Taken from document 322170-028 (5 series specification update).
Tested on out-of-tree HP ProBook 6550b (HM57), fixes several issues. Without this patch, EHCI controllers had no IRQ assigned and there were unexpected exceptions about NMIs. With this patch, the issues are gone.
Change-Id: Icd31dd89ba49e38a5e4c108a8361dbf636332ab8 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/51066 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Arthur Heymans arthur@aheymans.xyz Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/include/device/pci_ids.h M src/southbridge/intel/ibexpeak/lpc.c 2 files changed, 20 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Arthur Heymans: Looks good to me, approved
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index 475d0a8..d99f307 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -2768,8 +2768,18 @@ #define PCI_DEVICE_ID_INTEL_DENVERTON_TRACEHUB 0x19e1
/* Intel Ibex Peak (5 Series Chipset and 3400 Series Chipset) */ +#define PCI_DID_INTEL_IBEXPEAK_LPC_P55 0x3b02 +#define PCI_DID_INTEL_IBEXPEAK_LPC_PM55 0x3b03 +#define PCI_DID_INTEL_IBEXPEAK_LPC_H55 0x3b06 #define PCI_DID_INTEL_IBEXPEAK_LPC_QM57 0x3b07 +#define PCI_DID_INTEL_IBEXPEAK_LPC_H57 0x3b08 #define PCI_DID_INTEL_IBEXPEAK_LPC_HM55 0x3b09 +#define PCI_DID_INTEL_IBEXPEAK_LPC_Q57 0x3b0a +#define PCI_DID_INTEL_IBEXPEAK_LPC_HM57 0x3b0b +#define PCI_DID_INTEL_IBEXPEAK_LPC_QS57 0x3b0f +#define PCI_DID_INTEL_IBEXPEAK_LPC_3400 0x3b12 +#define PCI_DID_INTEL_IBEXPEAK_LPC_3420 0x3b14 +#define PCI_DID_INTEL_IBEXPEAK_LPC_3450 0x3b16 #define PCI_DID_INTEL_IBEXPEAK_MOBILE_SATA_IDE_1 0x3b28 #define PCI_DID_INTEL_IBEXPEAK_MOBILE_SATA_AHCI 0x3b29 #define PCI_DID_INTEL_IBEXPEAK_MOBILE_SATA_IDE_2 0x3b2e diff --git a/src/southbridge/intel/ibexpeak/lpc.c b/src/southbridge/intel/ibexpeak/lpc.c index ed0e03c..706df25 100644 --- a/src/southbridge/intel/ibexpeak/lpc.c +++ b/src/southbridge/intel/ibexpeak/lpc.c @@ -563,8 +563,18 @@ };
static const unsigned short pci_device_ids[] = { + PCI_DID_INTEL_IBEXPEAK_LPC_P55, + PCI_DID_INTEL_IBEXPEAK_LPC_PM55, + PCI_DID_INTEL_IBEXPEAK_LPC_H55, PCI_DID_INTEL_IBEXPEAK_LPC_QM57, + PCI_DID_INTEL_IBEXPEAK_LPC_H57, PCI_DID_INTEL_IBEXPEAK_LPC_HM55, + PCI_DID_INTEL_IBEXPEAK_LPC_Q57, + PCI_DID_INTEL_IBEXPEAK_LPC_HM57, + PCI_DID_INTEL_IBEXPEAK_LPC_QS57, + PCI_DID_INTEL_IBEXPEAK_LPC_3400, + PCI_DID_INTEL_IBEXPEAK_LPC_3420, + PCI_DID_INTEL_IBEXPEAK_LPC_3450, 0 };