Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33993 )
Change subject: mainboard/amd: Add padmelon board code
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33993/9/src/mainboard/amd/padmelon/...
File src/mainboard/amd/padmelon/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/33993/9/src/mainboard/amd/padmelon/...
PS9, Line 19: #if CONFIG(HAVE_MERLINFALCON_BINARIES)
: # { {0xA0, 0x00}, {0xA2, 0x00} }, // socket 0 - Channel 0 & 1, slot 0
: #else
: { {0xA0, 0x00} }, // socket 0 - Channel 0, slot 0
: #endif
:
This is a bad solution, it shows what needs to happen, but the "#" has to be moved manually. Working on finding a better solution.
If someone knows a better way, please do point me out.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33993
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5a366ddeb4cfebd177a8744f6edb87aecd4787dd
Gerrit-Change-Number: 33993
Gerrit-PatchSet: 9
Gerrit-Owner: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 11 Jul 2019 02:59:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment