Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42499 )
Change subject: mb/google/beltino/**/hda_verb.c: Correct mic pin configs ......................................................................
mb/google/beltino/**/hda_verb.c: Correct mic pin configs
Commit 0558d0c [mb/google/beltino/**/hda_verb.c: Correct pin configs] incorrectly flipped the mic pin configs for verb NIDs 0x18 and 0x19, so set them back to the correct values, which match the original Chromium sources (where the identifer in the NID comments were flipepd, which was the source of the confusion originally_.
Test: build/boot panther and zako variants, verify mic attached to 3.5mm jack functional
Change-Id: I172a0bb299049d113a0272ee9c790b25b6242cad Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/beltino/variants/mccloud/hda_verb.c M src/mainboard/google/beltino/variants/panther/hda_verb.c M src/mainboard/google/beltino/variants/tricky/hda_verb.c M src/mainboard/google/beltino/variants/zako/hda_verb.c 4 files changed, 20 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/42499/1
diff --git a/src/mainboard/google/beltino/variants/mccloud/hda_verb.c b/src/mainboard/google/beltino/variants/mccloud/hda_verb.c index 878314b..c45b409 100644 --- a/src/mainboard/google/beltino/variants/mccloud/hda_verb.c +++ b/src/mainboard/google/beltino/variants/mccloud/hda_verb.c @@ -27,15 +27,15 @@ /* Pin Complex (NID 0x17) MONO Out - Disabled */ AZALIA_PIN_CFG(0, 0x17, 0x411111f0),
- /* Pin Complex (NID 0x18) MIC1 PORTB */ + /* Pin Complex (NID 0x18) MIC2 PORTF - Disabled */ + AZALIA_PIN_CFG(0, 0x18, 0x411111f0), + + /* Pin Complex (NID 0x19) MIC1 PORTB */ // group 1, cap 1 // black, jack detect // mic in, analog // connector, left panel - AZALIA_PIN_CFG(0, 0x18, 0x03a71011), - - /* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ - AZALIA_PIN_CFG(0, 0x19, 0x411111f0), + AZALIA_PIN_CFG(0, 0x19, 0x03a71011),
/* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), diff --git a/src/mainboard/google/beltino/variants/panther/hda_verb.c b/src/mainboard/google/beltino/variants/panther/hda_verb.c index 878314b..c45b409 100644 --- a/src/mainboard/google/beltino/variants/panther/hda_verb.c +++ b/src/mainboard/google/beltino/variants/panther/hda_verb.c @@ -27,15 +27,15 @@ /* Pin Complex (NID 0x17) MONO Out - Disabled */ AZALIA_PIN_CFG(0, 0x17, 0x411111f0),
- /* Pin Complex (NID 0x18) MIC1 PORTB */ + /* Pin Complex (NID 0x18) MIC2 PORTF - Disabled */ + AZALIA_PIN_CFG(0, 0x18, 0x411111f0), + + /* Pin Complex (NID 0x19) MIC1 PORTB */ // group 1, cap 1 // black, jack detect // mic in, analog // connector, left panel - AZALIA_PIN_CFG(0, 0x18, 0x03a71011), - - /* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ - AZALIA_PIN_CFG(0, 0x19, 0x411111f0), + AZALIA_PIN_CFG(0, 0x19, 0x03a71011),
/* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), diff --git a/src/mainboard/google/beltino/variants/tricky/hda_verb.c b/src/mainboard/google/beltino/variants/tricky/hda_verb.c index 878314b..c45b409 100644 --- a/src/mainboard/google/beltino/variants/tricky/hda_verb.c +++ b/src/mainboard/google/beltino/variants/tricky/hda_verb.c @@ -27,15 +27,15 @@ /* Pin Complex (NID 0x17) MONO Out - Disabled */ AZALIA_PIN_CFG(0, 0x17, 0x411111f0),
- /* Pin Complex (NID 0x18) MIC1 PORTB */ + /* Pin Complex (NID 0x18) MIC2 PORTF - Disabled */ + AZALIA_PIN_CFG(0, 0x18, 0x411111f0), + + /* Pin Complex (NID 0x19) MIC1 PORTB */ // group 1, cap 1 // black, jack detect // mic in, analog // connector, left panel - AZALIA_PIN_CFG(0, 0x18, 0x03a71011), - - /* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ - AZALIA_PIN_CFG(0, 0x19, 0x411111f0), + AZALIA_PIN_CFG(0, 0x19, 0x03a71011),
/* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0, 0x1a, 0x411111f0), diff --git a/src/mainboard/google/beltino/variants/zako/hda_verb.c b/src/mainboard/google/beltino/variants/zako/hda_verb.c index 878314b..c45b409 100644 --- a/src/mainboard/google/beltino/variants/zako/hda_verb.c +++ b/src/mainboard/google/beltino/variants/zako/hda_verb.c @@ -27,15 +27,15 @@ /* Pin Complex (NID 0x17) MONO Out - Disabled */ AZALIA_PIN_CFG(0, 0x17, 0x411111f0),
- /* Pin Complex (NID 0x18) MIC1 PORTB */ + /* Pin Complex (NID 0x18) MIC2 PORTF - Disabled */ + AZALIA_PIN_CFG(0, 0x18, 0x411111f0), + + /* Pin Complex (NID 0x19) MIC1 PORTB */ // group 1, cap 1 // black, jack detect // mic in, analog // connector, left panel - AZALIA_PIN_CFG(0, 0x18, 0x03a71011), - - /* Pin Complex (NID 0x19) MIC2 PORTF - Disabled */ - AZALIA_PIN_CFG(0, 0x19, 0x411111f0), + AZALIA_PIN_CFG(0, 0x19, 0x03a71011),
/* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */ AZALIA_PIN_CFG(0, 0x1a, 0x411111f0),