Attention is currently required from: Jason Nien, Jon Murphy, Martin Roth.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79793?usp=email )
Change subject: mb/google/guybrush: Update DDI descriptor definition
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/guybrush/variants/baseboard/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/79793/comment/911c2d18_a29f107a :
PS2, Line 36: .connector_type = DDI_EDP,
: .aux_index = DDI_AUX1,
: .hdp_index = DDI_HDP1
We can. […]
True. Maybe just delete the `baseboard/variant.c` file to force each variant to define the `variant_has_hdmi`. This way it's explicit and no one "forgets" or "doesn't know about" the function.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79793?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib4ecbaaab5a21c30a67777a4522dc579cc9fa7e6
Gerrit-Change-Number: 79793
Gerrit-PatchSet: 2
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Fri, 05 Jan 2024 17:14:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Jon Murphy
jpmurphy@google.com
Gerrit-MessageType: comment