Xi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44703 )
Change subject: soc/mediatek/mt8192: Do EMI init before dram calibration ......................................................................
Patch Set 42:
(5 comments)
https://review.coreboot.org/c/coreboot/+/44703/41/src/soc/mediatek/mt8192/em... File src/soc/mediatek/mt8192/emi.c:
https://review.coreboot.org/c/coreboot/+/44703/41/src/soc/mediatek/mt8192/em... PS41, Line 362: setting_2
setting2
Ack
https://review.coreboot.org/c/coreboot/+/44703/41/src/soc/mediatek/mt8192/em... PS41, Line 371: write32(&emi_reg->chn_hash0, read32(&emi_reg->chn_hash0) | emi_temp_data);
Use clrsetbits32()
Ack
https://review.coreboot.org/c/coreboot/+/44703/41/src/soc/mediatek/mt8192/em... PS41, Line 386: write32(&ch[0].emi_chn.rkarb0, read32(&ch[0].emi_chn.rkarb0) | tmp);
Use clrsetbits32()
Ack
https://review.coreboot.org/c/coreboot/+/44703/41/src/soc/mediatek/mt8192/em... PS41, Line 389: u32
void
Ack
https://review.coreboot.org/c/coreboot/+/44703/41/src/soc/mediatek/mt8192/em... PS41, Line 389: u32
void
Ack