Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32448 )
Change subject: mb/google/octopus: Clear the GPI IS & IE registers ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32448/1/src/mainboard/google/octopus/mainboa... File src/mainboard/google/octopus/mainboard.c:
https://review.coreboot.org/#/c/32448/1/src/mainboard/google/octopus/mainboa... PS1, Line 74: gpi_clear_int_cfg
I don't think this is something mainboard specific. It applies to all boards. […]
I prefer that too. But I did this way since I wasn't sure about the right location in intel common code to invoke this function. I can see GPI SMI STS registers are cleared in common smihandler.c. But I am not sure if that is the right location to invoke this function.
Another lame reason is to rollout invoking this function in a phased manner so that I am not causing any side effect in other SoCs/mainboards. But definitely open to putting in common intel code.