Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/35947 )
Change subject: em100: Detect emulated flash chip ......................................................................
Patch Set 4:
(6 comments)
https://review.coreboot.org/c/em100/+/35947/3/em100.c File em100.c:
https://review.coreboot.org/c/em100/+/35947/3/em100.c@573 PS3, Line 573: *
This is good but please also document the args […]
Done
https://review.coreboot.org/c/em100/+/35947/3/em100.c@579 PS3, Line 579: uint16_t
I feel this could be int or unsigned int. […]
It returns exactly two bytes, so this seems reasonable.
https://review.coreboot.org/c/em100/+/35947/3/em100.c@581 PS3, Line 581: int
blank line after decl
Done
https://review.coreboot.org/c/em100/+/35947/3/em100.c@588 PS3, Line 588: return
blank line before return
Done
https://review.coreboot.org/c/em100/+/35947/3/em100.c@595 PS3, Line 595: *
Please document args
I'll leave this one to Patrick in a later patch, since this comment is better than what I originally wrote for many of the static functions in the code.
https://review.coreboot.org/c/em100/+/35947/3/em100.c@611 PS3, Line 611: uint16_t comp;
blank line after decl
Done