Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33102 )
Change subject: ec/apple: Add ACPI code for Apple MacBooks ......................................................................
Patch Set 10: Code-Review+1
(3 comments)
Can you autodetect the EC version at runtime? Some have revision registers in the EC space.
https://review.coreboot.org/#/c/33102/10/src/ec/apple/acpi/ac_01.asl File src/ec/apple/acpi/ac_01.asl:
https://review.coreboot.org/#/c/33102/10/src/ec/apple/acpi/ac_01.asl@34 PS10, Line 34: return(HPAC) Return
https://review.coreboot.org/#/c/33102/10/src/ec/apple/acpi/ac_60.asl File src/ec/apple/acpi/ac_60.asl:
https://review.coreboot.org/#/c/33102/10/src/ec/apple/acpi/ac_60.asl@34 PS10, Line 34: return(HPAC) Return
https://review.coreboot.org/#/c/33102/10/src/ec/apple/acpi/lid_01.asl File src/ec/apple/acpi/lid_01.asl:
https://review.coreboot.org/#/c/33102/10/src/ec/apple/acpi/lid_01.asl@34 PS10, Line 34: return(LIDS) Return