[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Dump ME f/w version and status information.

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32527 )

Change subject: soc/intel/cannonlake: Dump ME f/w version and status information.
......................................................................

Patch Set 6:

(3 comments)

https://review.coreboot.org/#/c/32527/6/src/soc/intel/cannonlake/me.c 
File src/soc/intel/cannonlake/me.c:

https://review.coreboot.org/#/c/32527/6/src/soc/intel/cannonlake/me.c@168 
PS6, Line 168: (void)unused;
I don't think this is required.

https://review.coreboot.org/#/c/32527/6/src/soc/intel/cannonlake/me.c@238 
PS6, Line 238: dump_me_status
One thing to check would be when Heci is disabled. +Subrata, can you please confirm this?

https://review.coreboot.org/#/c/32527/6/src/soc/intel/cannonlake/me.c@248 
PS6, Line 248: (void)unused;
Why?