Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34942 )
Change subject: inteltool: add Lewisburg C62x GPIOs support
......................................................................
Patch Set 15:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34942/7/util/inteltool/gpio.c
File util/inteltool/gpio.c:
https://review.coreboot.org/c/coreboot/+/34942/7/util/inteltool/gpio.c@1050
PS7, Line 1050: _PROD
I would remove the "PROD" suffix, as there's no naming clash with other parts.
Done
https://review.coreboot.org/c/coreboot/+/34942/7/util/inteltool/pcr.c
File util/inteltool/pcr.c:
PS7:
I guess the Super SKU is an unfused chip, with all the silicon features enabled. […]
Yes, I remember these wonderful AMD processors with 3 cores in the AM3 socket. And one more core could be unlocked :)
Ok, Thanks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34942
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43f8f3701de6ab7f89a78c2f5b939b5edd6d5b9d
Gerrit-Change-Number: 34942
Gerrit-PatchSet: 15
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Marius Genheimer
mail@f0wl.cc
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 04 Sep 2019 17:07:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Gerrit-MessageType: comment