Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46808 )
Change subject: mb/google/octopus/variants/bobba: Add G2Touch touchscreen support
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46808/2/src/mainboard/google/octopu...
File src/mainboard/google/octopus/variants/bobba/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46808/2/src/mainboard/google/octopu...
PS2, Line 216: ACPI_IRQ_EDGE_LOW
I2C-HID devices are expected to use level-triggered interrupts.
Please refer to commit [1] where mentioned that The first release of the HID over I2C specification mentioned that the level trigger needed to be active low. In the latest
version of the specification, there is no such explicit mention.
[1] https://chromium.googlesource.com/chromiumos/third_party/kernel/+/00f7fea5da...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46808
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia361a56c050d7cbd7325b3c09fc34d8707441cc4
Gerrit-Change-Number: 46808
Gerrit-PatchSet: 2
Gerrit-Owner: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marco Chen
marcochen@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 10 Nov 2020 14:38:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment