Robert Zieba has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/67747 )
Change subject: util/spd_tools: Change Mendocino to use 0x13 for LP5x memory type ......................................................................
util/spd_tools: Change Mendocino to use 0x13 for LP5x memory type
Mendocino supports LP5x but currently doesn't support SPDs that use the LP5x memory type, 0x15. This commit updates set 1 SPDs, which are currently only used for mendocino, to use 0x13 for their memory type.
BUG=b:245509394 TEST=Generated SPDs, verified that only set 1 have changed to 0x13
Change-Id: I46606cb5ff871296d0214e1f781c3b22e93d24ea Signed-off-by: Robert Zieba robertzieba@google.com --- M spd/lp5/set-1/spd-7.hex M spd/lp5/set-1/spd-8.hex M util/spd_tools/src/spd_gen/lp5.go 3 files changed, 24 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/67747/1
diff --git a/spd/lp5/set-1/spd-7.hex b/spd/lp5/set-1/spd-7.hex index 8b18d49..a38dbbd 100644 --- a/spd/lp5/set-1/spd-7.hex +++ b/spd/lp5/set-1/spd-7.hex @@ -1,4 +1,4 @@ -23 11 15 0E 86 21 95 18 00 40 00 00 02 02 00 00 +23 11 13 0E 86 21 95 18 00 40 00 00 02 02 00 00 00 00 03 00 00 00 00 00 2B 00 90 A8 90 C0 08 60 04 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/spd/lp5/set-1/spd-8.hex b/spd/lp5/set-1/spd-8.hex index 0602fef..e08c695 100644 --- a/spd/lp5/set-1/spd-8.hex +++ b/spd/lp5/set-1/spd-8.hex @@ -1,4 +1,4 @@ -23 11 15 0E 86 21 B5 18 00 40 00 00 0A 02 00 00 +23 11 13 0E 86 21 B5 18 00 40 00 00 0A 02 00 00 00 00 03 00 00 00 00 00 2B 00 90 A8 90 C0 08 60 04 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/util/spd_tools/src/spd_gen/lp5.go b/util/spd_tools/src/spd_gen/lp5.go index bf7b833..ddfc13a 100644 --- a/util/spd_tools/src/spd_gen/lp5.go +++ b/util/spd_tools/src/spd_gen/lp5.go @@ -466,7 +466,11 @@ func LP5EncodeMemoryType(memAttribs *LP5MemAttributes) byte { var b byte
- if memAttribs.LP5X { + /* + * Set 1 contains mendocino doesn't currently support SPDs with + * memory type set to 0x15. + */ + if memAttribs.LP5X && LP5CurrSet != 1 { b = LP5XSPDValueMemoryType } else { b = LP5SPDValueMemoryType