Attention is currently required from: Angel Pons, Arthur Heymans, Lean Sheng Tan, Werner Zeh.
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69383 )
Change subject: soc/intel/ehl: Add MDIO operation to TSN GbE device ......................................................................
Patch Set 11:
(4 comments)
File src/soc/intel/elkhartlake/tsn_gbe.c:
https://review.coreboot.org/c/coreboot/+/69383/comment/d65bdc5e_7055e202 PS10, Line 42: printk(BIOS_ALERT, "MDIO bus operations not available for %s.\n", : dev_path(dev));
There is a message on ERROR level already in dev_get_mdio_ops() (see https://review.coreboot. […]
I think we can do without this message. The reference to the PCI device is recognizable via log.
https://review.coreboot.org/c/coreboot/+/69383/comment/35150ee4_40246c9c PS10, Line 94:
Add a mdelay(1); here so that this time can be used elsewhere if needed? See src/lib/thread. […]
Done
https://review.coreboot.org/c/coreboot/+/69383/comment/7d915d2f_ad9c9eb7 PS10, Line 128: static void tsn_mdio_write(struct device *dev, uint8_t phy_adr, uint8_t reg_adr, : uint16_t data)
Looks like this could fit on one line (95 chars).
Done
https://review.coreboot.org/c/coreboot/+/69383/comment/d52c804c_0d58521f PS10, Line 143: do next
exit
Done