Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34564 )
Change subject: mb/up/squared: Fill LPDDR4 dimm info
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34564/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34564/3//COMMIT_MSG@11
PS3, Line 11: TODO: Find out how to read the memory sku id and support
update commit message
Done
https://review.coreboot.org/c/coreboot/+/34564/3/src/mainboard/up/squared/ro...
File src/mainboard/up/squared/romstage.c:
https://review.coreboot.org/c/coreboot/+/34564/3/src/mainboard/up/squared/ro...
PS3, Line 43: },
you need to add 3 more entries
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34564
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4de63362c8fea8a886594cdcf0eec48421afb605
Gerrit-Change-Number: 34564
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
Gerrit-Comment-Date: Thu, 12 Sep 2019 09:43:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
Gerrit-MessageType: comment