Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49086 )
Change subject: util/amdfwtool: clean up Makefile, Makefile.inc
......................................................................
Patch Set 1: Code-Review+1
I'm unsure about the HOSTCFLAGS vs. CFLAGS change in Makefile.inc; would be good if someone who knows the design of the build system and the intention behind those things a bit better comments on this one.
The change in Makefile looks good to me.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49086
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia16af046acdc68c176b1c4ff434518a5f8f8bf9e
Gerrit-Change-Number: 49086
Gerrit-PatchSet: 1
Gerrit-Owner: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 04 Jan 2021 23:07:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment