Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47523 )
Change subject: soc/intel/common: Add Kconfig to enable the CSE FW Update feature
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/47523/6/src/soc/intel/common/block/...
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/47523/6/src/soc/intel/common/block/...
PS6, Line 742: #if CONFIG(SOC_INTEL_CSE_RW_UPDATE)
Woops. Looks like my suggestion to add this config caused this addition of #ifs as well.. Humm.. I would really like to get rid of these #ifs, but let's do that as a follow-up. I don't want to make you go back and forth on this change. (Note for self: It is better to have the code compile tested using runtime checks instead of compile time checks here. Will need revisiting the Kconfig definitions to handle this).
We can take that up as follow-up once the entire series is landed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47523
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12810031224f79aba8a4057725ae0ed5a9b36d7e
Gerrit-Change-Number: 47523
Gerrit-PatchSet: 6
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 17 Nov 2020 03:45:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment