Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35014 )
Change subject: Move and rename ARCH_STAGE_HAS_xxx_SECTION rules ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35014/5/src/include/rules.h File src/include/rules.h:
https://review.coreboot.org/c/coreboot/+/35014/5/src/include/rules.h@277 PS5, Line 277: sometimes SRAM not DRAM
Wording "sometimes" does not define when exactly one changes from SRAM to DRAM. […]
Ack
https://review.coreboot.org/c/coreboot/+/35014/5/src/include/rules.h@278 PS5, Line 278: #define ENV_STAGE_HAS_DATA_SECTION 1 : #define ENV_STAGE_HAS_BSS_SECTION 1
CB:35016 and CB:35004 will touch these, making it more complex than !ENV_CACHE_AS_RAM for ARCH_X86. […]
Ack
https://review.coreboot.org/c/coreboot/+/35014/4/src/include/rules.h File src/include/rules.h:
https://review.coreboot.org/c/coreboot/+/35014/4/src/include/rules.h@270 PS4, Line 270: /* No .data or .bss sections. Cache as RAM is handled separately. */
Looking at x86/memlayout.ld, it includes <memlayout.h> which includes <xx/program. […]
Done