Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35164 )
Change subject: mediatek/mt8183: Use cached calibration result for faster bootup
......................................................................
Patch Set 24:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35164/12/src/soc/mediatek/mt8183/dr...
File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/35164/12/src/soc/mediatek/mt8183/dr...
PS12, Line 1617: for (u8 byte = 0; byte < DQS_NUMBER; byte++) {
Can’t you factor this out into a dedicated function?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35164
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ef4265dd369a1c276bb02294696556df927e7bc
Gerrit-Change-Number: 35164
Gerrit-PatchSet: 24
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 02 Oct 2019 06:46:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment