build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32708 )
Change subject: mb/gigabyte/ga-b75m-d3{h,v}: Switch to a variant setup ......................................................................
Patch Set 1:
(64 comments)
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... File src/mainboard/gigabyte/ga-panther-point/variants/ga-b75m-d3h/include/variant/mainboard_init.h:
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 6: RCBA32(0x38c8) = 0x00002005; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 7: RCBA32(0x38c4) = 0x00802005; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 8: RCBA32(0x2240) = 0x00330e71; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 9: RCBA32(0x2244) = 0x003f0eb1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 10: RCBA32(0x2248) = 0x002102cd; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 11: RCBA32(0x224c) = 0x00f60000; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 12: RCBA32(0x2250) = 0x00020000; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 13: RCBA32(0x2254) = 0x00e3004c; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 14: RCBA32(0x2258) = 0x00e20bef; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 15: RCBA32(0x2260) = 0x003304ed; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 16: RCBA32(0x2278) = 0x001107c1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 17: RCBA32(0x227c) = 0x001d07e9; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 18: RCBA32(0x2280) = 0x00e20000; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 19: RCBA32(0x2284) = 0x00ee0000; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 20: RCBA32(0x2288) = 0x005b05d3; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 21: RCBA32(0x2318) = 0x04b8ff2e; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 22: RCBA32(0x231c) = 0x03930f2e; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 23: RCBA32(0x3808) = 0x005044a3; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 24: RCBA32(0x3810) = 0x52410000; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 25: RCBA32(0x3814) = 0x0000008a; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 26: RCBA32(0x3818) = 0x00000006; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 27: RCBA32(0x381c) = 0x0000072e; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 28: RCBA32(0x3820) = 0x0000000a; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 29: RCBA32(0x3824) = 0x00000123; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 30: RCBA32(0x3828) = 0x00000009; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 31: RCBA32(0x382c) = 0x00000001; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 32: RCBA32(0x3834) = 0x0000061a; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 33: RCBA32(0x3838) = 0x00000003; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 34: RCBA32(0x383c) = 0x00000a76; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 35: RCBA32(0x3840) = 0x00000004; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 36: RCBA32(0x3844) = 0x0000e5e4; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 37: RCBA32(0x3848) = 0x0000000e; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... File src/mainboard/gigabyte/ga-panther-point/variants/ga-b75m-d3v/include/variant/mainboard_init.h:
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 6: RCBA32(0x38c8) = 0x00002005; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 7: RCBA32(0x38c4) = 0x00802005; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 8: RCBA32(0x2240) = 0x00330e71; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 9: RCBA32(0x2244) = 0x003f0eb1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 10: RCBA32(0x2248) = 0x002102cd; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 11: RCBA32(0x224c) = 0x00f60000; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 12: RCBA32(0x2250) = 0x00020000; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 13: RCBA32(0x2254) = 0x00e3004c; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 14: RCBA32(0x2258) = 0x00e20bef; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 15: RCBA32(0x2260) = 0x003304ed; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 16: RCBA32(0x2278) = 0x001107c1; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 17: RCBA32(0x227c) = 0x001d07e9; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 18: RCBA32(0x2280) = 0x00e20000; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 19: RCBA32(0x2284) = 0x00ee0000; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 20: RCBA32(0x2288) = 0x005b05d3; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 21: RCBA32(0x2318) = 0x04b8ff2e; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 22: RCBA32(0x231c) = 0x03930f2e; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 23: RCBA32(0x3808) = 0x005044a3; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 24: RCBA32(0x3810) = 0x52410000; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 25: RCBA32(0x3814) = 0x0000008a; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 26: RCBA32(0x3818) = 0x00000006; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 27: RCBA32(0x381c) = 0x0000072e; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 28: RCBA32(0x3820) = 0x0000000a; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 29: RCBA32(0x3824) = 0x00000123; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 30: RCBA32(0x3828) = 0x00000009; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 31: RCBA32(0x382c) = 0x00000001; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 32: RCBA32(0x3834) = 0x0000061a; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 33: RCBA32(0x3838) = 0x00000003; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 34: RCBA32(0x383c) = 0x00000a76; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 35: RCBA32(0x3840) = 0x00000004; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 36: RCBA32(0x3844) = 0x0000e5e4; please, no spaces at the start of a line
https://review.coreboot.org/#/c/32708/1/src/mainboard/gigabyte/ga-panther-po... PS1, Line 37: RCBA32(0x3848) = 0x0000000e; please, no spaces at the start of a line