Mimoja has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34599 )
Change subject: lib/coreboot_table: Show splashscreen in lb_table_init
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34599/7/src/lib/coreboot_table.c
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/34599/7/src/lib/coreboot_table.c@15...
PS7, Line 150: if (CONFIG(BOOTSPLASH)) {
I would rather see the call made outside coreboot-table but apparently Nico was against hooking to […]
While I fully agree that that would be nice, I also think that it should not be handled now / in the review. Refactoring the notification system might require more than just 15 lines and a bit of planning.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34599
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4bec06d22423627e8f429c4b47e0dc9920f1464e
Gerrit-Change-Number: 34599
Gerrit-PatchSet: 9
Gerrit-Owner: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Gerd Hoffmann
kraxel@redhat.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Tue, 30 Jul 2019 22:24:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Mimoja
coreboot@mimoja.de
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment