Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45056 )
Change subject: soc/amd/picasso: Add MADT entry for GNB IOAPIC ......................................................................
Patch Set 6:
(6 comments)
https://review.coreboot.org/c/coreboot/+/45056/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45056/2//COMMIT_MSG@7 PS2, Line 7: Fix hang caused by IVRS
Also update the commit message to describe what the patch does.
Done
https://review.coreboot.org/c/coreboot/+/45056/2//COMMIT_MSG@21 PS2, Line 21: Signed-off-by
Ack
Done
https://review.coreboot.org/c/coreboot/+/45056/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45056/5//COMMIT_MSG@7 PS5, Line 7: soc/amd/picasso/acpi: Add MADT entry for NB ioapic, if initialized.
Please remove the dot/period at the end of the git commit message summary.
Done
https://review.coreboot.org/c/coreboot/+/45056/2/src/soc/amd/picasso/acpi.c File src/soc/amd/picasso/acpi.c:
https://review.coreboot.org/c/coreboot/+/45056/2/src/soc/amd/picasso/acpi.c@... PS2, Line 55: 0 - max logical cpus - 1
Ack
Done
https://review.coreboot.org/c/coreboot/+/45056/2/src/soc/amd/picasso/acpi.c@... PS2, Line 64: nb_ioapic_base
Ack
Done
https://review.coreboot.org/c/coreboot/+/45056/5/src/soc/amd/picasso/acpi.c File src/soc/amd/picasso/acpi.c:
https://review.coreboot.org/c/coreboot/+/45056/5/src/soc/amd/picasso/acpi.c@... PS5, Line 59: CONFIG_MAX_CPUS
Agree. […]
Added in CB:45115