Attention is currently required from: Martin Roth, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52475 )
Change subject: mb/hp: Add Compal LA-A992P ......................................................................
Patch Set 4:
(17 comments)
File src/mainboard/hp/hp_15_notebook_pc/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117272): https://review.coreboot.org/c/coreboot/+/52475/comment/2c322977_8edf0c23 PS4, Line 15: /* 00 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x40, 0x00, 0x00, 0x00, 0xff, 0x04, 0x00, 0x00, 0x12, 0x01, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117272): https://review.coreboot.org/c/coreboot/+/52475/comment/8bb78850_b10174ea PS4, Line 16: /* 10 */ 0x01, 0x1b, 0x33, 0x1b, 0x00, 0x00, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0x00, 0x04, 0x03, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117272): https://review.coreboot.org/c/coreboot/+/52475/comment/a83caa1c_a444a3a3 PS4, Line 17: /* 20 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117272): https://review.coreboot.org/c/coreboot/+/52475/comment/049e29b2_16126f70 PS4, Line 18: /* 30 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117272): https://review.coreboot.org/c/coreboot/+/52475/comment/eab63a1b_d97dd499 PS4, Line 19: /* 40 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117272): https://review.coreboot.org/c/coreboot/+/52475/comment/5cf9470f_9fc6122f PS4, Line 20: /* 50 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117272): https://review.coreboot.org/c/coreboot/+/52475/comment/1e8209d9_0a70bed4 PS4, Line 21: /* 60 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117272): https://review.coreboot.org/c/coreboot/+/52475/comment/516cf1e3_1818a15e PS4, Line 22: /* 70 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117272): https://review.coreboot.org/c/coreboot/+/52475/comment/4602d110_9de6dc13 PS4, Line 23: /* 80 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117272): https://review.coreboot.org/c/coreboot/+/52475/comment/b06e7354_a6363f19 PS4, Line 24: /* 90 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117272): https://review.coreboot.org/c/coreboot/+/52475/comment/f674d7fc_d34655a0 PS4, Line 25: /* a0 */ 0x00, 0x04, 0x00, 0x86, 0xc1, 0x00, 0x00, 0x61, 0x63, 0x00, 0x00, 0x08, 0x64, 0x1a, 0x00, 0xf0, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117272): https://review.coreboot.org/c/coreboot/+/52475/comment/a6d60f68_21077dc6 PS4, Line 26: /* b0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x09, 0x00, 0x00, 0x32, 0x02, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117272): https://review.coreboot.org/c/coreboot/+/52475/comment/69f385bf_b8d83de5 PS4, Line 27: /* c0 */ 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117272): https://review.coreboot.org/c/coreboot/+/52475/comment/7358dae0_4a8ea377 PS4, Line 28: /* d0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117272): https://review.coreboot.org/c/coreboot/+/52475/comment/06f0db0c_5966698d PS4, Line 29: /* e0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117272): https://review.coreboot.org/c/coreboot/+/52475/comment/c7364ecd_f59a6958 PS4, Line 30: /* f0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117272): https://review.coreboot.org/c/coreboot/+/52475/comment/d6e7c2a1_0742a32c PS4, Line 35: ec_write (i, dmp[i]); space prohibited between function name and open parenthesis '('