Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39301 )
Change subject: mb/google/volteer: add new ripto variant ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/39301/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/Kconfig:
https://review.coreboot.org/c/coreboot/+/39301/1/src/mainboard/google/voltee... PS1, Line 59: default "Ripto" if BOARD_GOOGLE_RIPTO Please add in alphabetical order.
https://review.coreboot.org/c/coreboot/+/39301/1/src/mainboard/google/voltee... PS1, Line 72: default "ripto" if BOARD_GOOGLE_RIPTO same here
https://review.coreboot.org/c/coreboot/+/39301/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/ripto/gpio.c:
https://review.coreboot.org/c/coreboot/+/39301/1/src/mainboard/google/voltee... PS1, Line 469: extra blank line not required.
https://review.coreboot.org/c/coreboot/+/39301/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/ripto/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39301/1/src/mainboard/google/voltee... PS1, Line 3: # Limit L1.1(value:2) for RP9, RP11 : #register "PcieRpL1Substates[8]" = "2" : #register "PcieRpL1Substates[10]" = "2" Drop commented out code?