Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33824 )
Change subject: mainboard/google/hatch: create akemi variant.
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33824/10/src/mainboard/google/hatch...
File src/mainboard/google/hatch/variants/akemi/gpio.c:
https://review.coreboot.org/c/coreboot/+/33824/10/src/mainboard/google/hatch...
PS10, Line 33: /* A0 : NC */
: PAD_NC(GPP_A0, NONE),
: /* A6 : NC */
: PAD_NC(GPP_A6, NONE),
: /* A8 : NC */
: PAD_NC(GPP_A8, NONE),
: /* A10 : NC */
: PAD_NC(GPP_A10, NONE),
: /* A11 : NC */
: PAD_NC(GPP_A11, NONE),
: /* A12 : NC */
: PAD_NC(GPP_A12, NONE),
: /* A18 : NC */
: PAD_NC(GPP_A18, NONE),
: /* A19 : NC */
: PAD_NC(GPP_A19, NONE),
: /* A22 : NC */
: PAD_NC(GPP_A22, NONE),
: /* A23 : NC */
: PAD_NC(GPP_A23, NONE),
: /* B20 : NC */
: PAD_NC(GPP_B20, NONE),
: /* B21 : NC */
: PAD_NC(GPP_B21, NONE),
: /* B22 : NC */
: PAD_NC(GPP_B22, NONE),
: /* C11 : NC */
: PAD_NC(GPP_C11, NONE),
: /* F1 : NC */
: PAD_NC(GPP_F1, NONE),
configure GPIO according to real schematic.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33824
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a868839e2c598f8052d37c99713bc58b21e887c
Gerrit-Change-Number: 33824
Gerrit-PatchSet: 13
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Marx Wang
marx.wang@intel.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Paul Ma
magf@bitland.corp-partner.google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Xingyu Wu
wuxy@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 05 Aug 2019 01:31:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment