Attention is currently required from: EricR Lai. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48446 )
Change subject: mb/google/brya: Add memory DQ map ......................................................................
Patch Set 6:
(3 comments)
File src/mainboard/google/brya/romstage.c:
https://review.coreboot.org/c/coreboot/+/48446/comment/84967a17_4e8ab5f4 PS6, Line 12: ; ()
File src/mainboard/google/brya/variants/baseboard/memory.c:
https://review.coreboot.org/c/coreboot/+/48446/comment/b3e6ebb7_47f2eced PS6, Line 68: /* Memory configuration board straps */ : #define GPIO_MEM_CONFIG_0 GPP_E11 : #define GPIO_MEM_CONFIG_1 GPP_E2 : #define GPIO_MEM_CONFIG_2 GPP_E1 : #define GPIO_MEM_CONFIG_3 GPP_E12 I think we can just drop the macros completely.
https://review.coreboot.org/c/coreboot/+/48446/comment/31e54899_b0d0ba1a PS6, Line 86: #define GPIO_MEM_CH_SEL GPP_E13 Not really required. You can use GPP_E13 directly.