Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36382 )
Change subject: cpu/x86/mtrr: Add function to set MTRR with CR0.CD set ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36382/1/src/cpu/x86/mtrr/Makefile.i... File src/cpu/x86/mtrr/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36382/1/src/cpu/x86/mtrr/Makefile.i... PS1, Line 7: verstage-y += set_mtrr.S Does this file always work for 64-bit?
https://review.coreboot.org/c/coreboot/+/36382/1/src/cpu/x86/mtrr/set_mtrr.S File src/cpu/x86/mtrr/set_mtrr.S:
https://review.coreboot.org/c/coreboot/+/36382/1/src/cpu/x86/mtrr/set_mtrr.S... PS1, Line 32: pushl %edi pusha ?
https://review.coreboot.org/c/coreboot/+/36382/1/src/include/cpu/x86/mtrr.h File src/include/cpu/x86/mtrr.h:
https://review.coreboot.org/c/coreboot/+/36382/1/src/include/cpu/x86/mtrr.h@... PS1, Line 112: __attribute__((cdecl)) asmlinkage exists for this purpose