Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36642 )
Change subject: drivers/i2c/ptn3460: Provide chip driver for PTN3460
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/36642/2/src/drivers/i2c/ptn3460/ptn...
File src/drivers/i2c/ptn3460/ptn3460.c:
https://review.coreboot.org/c/coreboot/+/36642/2/src/drivers/i2c/ptn3460/ptn...
PS2, Line 80: status, i, val
You could have used "val" for every call to the ptn3460_xxx-functions (so even for ptn3460_write_edid) and get rid of status at all. Your decision.
https://review.coreboot.org/c/coreboot/+/36642/2/src/drivers/i2c/ptn3460/ptn...
PS2, Line 106: Not able
This could have been 'Unable' to sync with the case above. But I do not have a strong objection.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36642
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4c8176cd16836fa5b8fd2f72faf7a55723b82f6
Gerrit-Change-Number: 36642
Gerrit-PatchSet: 2
Gerrit-Owner: uwe taz
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: uwe taz
Gerrit-Reviewer: uwe.poeche@siemens.com
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Tue, 12 Nov 2019 06:12:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
