Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35032 )
Change subject: timestamps: Improve collection for ENV_ROMSTAGE_OR_BEFORE ......................................................................
Patch Set 8:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35032/7/src/include/timestamp.h File src/include/timestamp.h:
https://review.coreboot.org/c/coreboot/+/35032/7/src/include/timestamp.h@26 PS7, Line 26: * to make *one* call per stage, otherwise some timestamps will be lost.
Not intentional, just confusions after looking into if cbmem_init() is necessary for ramstage and ma […]
Done
https://review.coreboot.org/c/coreboot/+/35032/7/src/lib/timestamp.c File src/lib/timestamp.c:
https://review.coreboot.org/c/coreboot/+/35032/7/src/lib/timestamp.c@124 PS7, Line 124: return car_get_ptr(glob_ts_table);
Right, I guess we don't need cbmem_find() because CBMEM recovery always sets the pointer already.
Ack
https://review.coreboot.org/c/coreboot/+/35032/7/src/lib/timestamp.c@172 PS7, Line 172: timestamp_add_table_entry(ts_table, id, ts_time);
I'll put it back.
Done
https://review.coreboot.org/c/coreboot/+/35032/8/src/lib/timestamp.c File src/lib/timestamp.c:
https://review.coreboot.org/c/coreboot/+/35032/8/src/lib/timestamp.c@203 PS8, Line 203: if (!ENV_ROMSTAGE_OR_BEFORE)
nit: Should this maybe just be an assert()? Because doing this is just incorrect now, right? We can […]
(was supposed to be non-blocking)