Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41385 )
Change subject: soc/intel/tigerlake: Move PMC PCI resources under PMC device
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41385/3/src/soc/intel/tigerlake/chi...
File src/soc/intel/tigerlake/chip.c:
https://review.coreboot.org/c/coreboot/+/41385/3/src/soc/intel/tigerlake/chi...
PS3, Line 159: .acpi_name = &soc_acpi_name,
We already added PMC to soc_acpi_name for tigerlake; PCI devices usually get their ACPI name from so […]
Yes, I'm familiar. However, there's no point in specifying soc_acpi_name() for the pmc device when it can provide it's own function or leave it to NULL and let it walk up the hierarchy (see acpi_device_name() in acpi/device.c). I personally prefer to make it explicit in the ops we're adding for device binding.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41385
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia7c6ae849aefaf549fb682416a87320907fb3fe3
Gerrit-Change-Number: 41385
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 14 May 2020 17:29:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment