Attention is currently required from: Michael Niewöhner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48383 )
Change subject: mb/fujitsu/d3410-b1: Add new mainboard ......................................................................
Patch Set 5:
(4 comments)
File src/mainboard/fujitsu/d3410-b1/Kconfig:
https://review.coreboot.org/c/coreboot/+/48383/comment/d124fc69_0c21de54 PS5, Line 34: config USE_LEGACY_8254_TIMER
what for?
I recall having issues without it, I'll re-check
File src/mainboard/fujitsu/d3410-b1/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48383/comment/f5234b40_4d07001a PS5, Line 77: register "SataTestMode" = "1
this is not something that should be merged
Fine, I'll make it a Kconfig option instead.
https://review.coreboot.org/c/coreboot/+/48383/comment/ffdf2efe_8ce8f296 PS5, Line 126: irq 0x70 = 1 : irq 0x72 = 12
why mixing hex with decimal?
IRQ numbers are usually written in decimal, whereas addresses and register offsets are most often hex.
https://review.coreboot.org/c/coreboot/+/48383/comment/33cb3000_888b288e PS5, Line 163: io 0x62 = 0 : irq 0x70 = 0 :
why mixing hex with decimal?
In this case, it's to emphasize that these are disabled.