Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34788 )
Change subject: mb/google/hatch/var/kindred: Config GPIOs and disable eMMC for SSD SKUs ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34788/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kindred/gpio.c:
https://review.coreboot.org/c/coreboot/+/34788/2/src/mainboard/google/hatch/... PS2, Line 137: switch (sku_id) { All of the cases (except for default) have the same body - they all use ssd_sku_gpio_table. In https://review.coreboot.org/c/coreboot/+/34789, the comments in variant.c say "SKU ID 2/4/21/22 doesn't have a SSD device, hence disable it." So why are the SSD GPIOs being used for those SKUs? If the SKUs are being grouped this way because there will be additional statements in the bodies in the future, you should note that in some comments. Otherwise, all of the case labels with the same body should be together with a single body.