[coreboot-gerrit] Change in coreboot[master]: mainboard: Add Synology DS918+

[Name of user not set (Code Review)]

Attention is currently required from:  Felix Singer, Martin Roth, Angel Pons, Michael Niewöhner.
Hello  Felix Singer, build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, Michael Niewöhner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/52594

to look at the new patch set (#5).

Change subject: mainboard: Add Synology DS918+
......................................................................

mainboard: Add Synology DS918+

I'm new to coreboot.
This port is based on 4.13, this board boots. Tested with tianocore.
Can provide serial logs, original Synology's DSM OS works fine with this
port. Can run tests on my board.
Now works on Master.
Things todo:
* polish
* I211 ethernet chips don't work in OS
* 2nd HSUART Serial doesn't work in OS, only in original DSM. Tried all
  console=ttyS*,115200 and all 'set tty com*' (as per obsd), probably
  not cb problem.
* Freebsd usb stick causes X86 exception, OpenBSD fails to boot at
  entry point 0x1001000. Both have apl support. log:
  https://clbin.com/JrurJ
* ...

Patch set 2
Reformated gpio part and dsdt.

Here are serial logs:
https://clbin.com/tHOE7 -- Master branch
https://clbin.com/wp4R8 -- 4.13 + seabios, same code except 1 include in
dsdt
https://clbin.com/iUrgJ -- 4.13 + tianocore, same code...

Video test:
https://schizoden.xyz/videos/watch/816c5a68-af6f-4dd4-8c7e-43d068410822

Patch set 3/4
More gpio reformating, added data.vbt from vendors bios.
* trim spare lines on the end, for jenkins sake

Patch set 5
Removed data.vbt, causes serial to shut off at post 0x98
Fixed cbfs>mem-mapped area from ifwi + MCACHE -400 err -- .fmd
Added cmos.layout cmos.default
Edited pci-e devices and turned on vtd in devicetree.cb

Change-Id: Ib837e0819c97a617e5558480e7cdac05e3cff185
Signed-off-by: mkjOoB 
---
A src/mainboard/synology/Kconfig
A src/mainboard/synology/Kconfig.name
A src/mainboard/synology/ds918plus/Kconfig
A src/mainboard/synology/ds918plus/Kconfig.name
A src/mainboard/synology/ds918plus/Makefile.inc
A src/mainboard/synology/ds918plus/board_info.txt
A src/mainboard/synology/ds918plus/bootblock.c
A src/mainboard/synology/ds918plus/cmos.default
A src/mainboard/synology/ds918plus/cmos.layout
A src/mainboard/synology/ds918plus/devicetree.cb
A src/mainboard/synology/ds918plus/ds918plus.fmd
A src/mainboard/synology/ds918plus/dsdt.asl
A src/mainboard/synology/ds918plus/early_gpio.c
A src/mainboard/synology/ds918plus/gpio.c
A src/mainboard/synology/ds918plus/gpio.h
A src/mainboard/synology/ds918plus/mainboard.c
A src/mainboard/synology/ds918plus/romstage.c
17 files changed, 642 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/52594/5