Attention is currently required from: Martin Roth, Matt DeVillier, Paul Menzel, Tim Wawrzynczak, Angel Pons.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 )
Change subject: [WIP] util: Add coreboot Configurator
......................................................................
Patch Set 27:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58854/comment/e8c8c047_bbb9f3f0
PS26, Line 9: simply
simple
Done
Patchset:
PS26:
Thank you for pushing this upstream. […]
Is that something I can do? (If so, can't see how!)
File util/coreboot-configurator/src/application/coreboot_configurator.cpp:
https://review.coreboot.org/c/coreboot/+/58854/comment/b7791749_1cf54f37
PS25, Line 206:
This is the reason for the jenkins build failure. […]
The bit I can't figure out how to please Jenkin's with is the `need consistent spacing around '*' (ctx:WxV)`
They are consistent - making them inconsistent makes him even less happy :/
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58854
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie654f6aca57a792be0c295afc081a95ed4d875d1
Gerrit-Change-Number: 58854
Gerrit-PatchSet: 27
Gerrit-Owner: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Angel Pons
angel.pons@9elements.com
Gerrit-Comment-Date: Sun, 07 Nov 2021 22:19:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment