build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31774 )
Change subject: coreboot: Replace all IS_ENABLED(CONFIG_XXX) with CONFIG(XXX) ......................................................................
Patch Set 2:
(28 comments)
https://review.coreboot.org/#/c/31774/2/src/console/printk.c File src/console/printk.c:
https://review.coreboot.org/#/c/31774/2/src/console/printk.c@29 PS2, Line 29: #if (!defined(__PRE_RAM__) && CONFIG(HAVE_ROMSTAGE_CONSOLE_SPINLOCK)) || !CONFIG(HAVE_ROMSTAGE_CONSOLE_SPINLOCK) line over 96 characters
https://review.coreboot.org/#/c/31774/2/src/cpu/amd/pi/00630F01/fixme.c File src/cpu/amd/pi/00630F01/fixme.c:
https://review.coreboot.org/#/c/31774/2/src/cpu/amd/pi/00630F01/fixme.c@91 PS2, Line 91: if (CONFIG(UDELAY_LAPIC)){ space required before the open brace '{'
https://review.coreboot.org/#/c/31774/2/src/device/pci_rom.c File src/device/pci_rom.c:
https://review.coreboot.org/#/c/31774/2/src/device/pci_rom.c@58 PS2, Line 58: } else if (!CONFIG(ON_DEVICE_ROM_LOAD)) { suspect code indent for conditional statements (8, 24)
https://review.coreboot.org/#/c/31774/2/src/drivers/pc80/tpm/tis.c File src/drivers/pc80/tpm/tis.c:
https://review.coreboot.org/#/c/31774/2/src/drivers/pc80/tpm/tis.c@129 PS2, Line 129: #if CONFIG(TPM2) braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31774/2/src/drivers/spi/spi_flash.c File src/drivers/spi/spi_flash.c:
https://review.coreboot.org/#/c/31774/2/src/drivers/spi/spi_flash.c@279 PS2, Line 279: #if CONFIG(SPI_FLASH_AMIC) braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31774/2/src/drivers/spi/spi_flash.c@282 PS2, Line 282: #if CONFIG(SPI_FLASH_ATMEL) braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31774/2/src/drivers/spi/spi_flash.c@285 PS2, Line 285: #if CONFIG(SPI_FLASH_EON) braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31774/2/src/drivers/spi/spi_flash.c@288 PS2, Line 288: #if CONFIG(SPI_FLASH_GIGADEVICE) braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31774/2/src/drivers/spi/spi_flash.c@291 PS2, Line 291: #if CONFIG(SPI_FLASH_MACRONIX) braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31774/2/src/drivers/spi/spi_flash.c@294 PS2, Line 294: #if CONFIG(SPI_FLASH_SPANSION) braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31774/2/src/drivers/spi/spi_flash.c@297 PS2, Line 297: #if CONFIG(SPI_FLASH_SST) braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31774/2/src/drivers/spi/spi_flash.c@300 PS2, Line 300: #if CONFIG(SPI_FLASH_STMICRO) braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31774/2/src/drivers/spi/spi_flash.c@303 PS2, Line 303: #if CONFIG(SPI_FLASH_WINBOND) braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31774/2/src/drivers/spi/spi_flash.c@307 PS2, Line 307: #if CONFIG(SPI_FLASH_STMICRO) braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31774/2/src/drivers/spi/spi_flash.c@310 PS2, Line 310: #if CONFIG(SPI_FLASH_ADESTO) braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31774/2/src/lib/prog_loaders.c File src/lib/prog_loaders.c:
https://review.coreboot.org/#/c/31774/2/src/lib/prog_loaders.c@84 PS2, Line 84: if (CONFIG(RESET_ON_INVALID_RAMSTAGE_CACHE)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31774/2/src/mainboard/amd/lamar/OemCustomize... File src/mainboard/amd/lamar/OemCustomize.c:
https://review.coreboot.org/#/c/31774/2/src/mainboard/amd/lamar/OemCustomize... PS2, Line 61: CONFIG(ENABLE_DP3_DAUGHTER_CARD_IN_J120) ? PcieUnusedEngine : PciePortEngine, line over 96 characters
https://review.coreboot.org/#/c/31774/2/src/mainboard/amd/lamar/OemCustomize... PS2, Line 81: CONFIG(ENABLE_DP3_DAUGHTER_CARD_IN_J120) ? PcieDdiEngine : PcieUnusedEngine, line over 96 characters
https://review.coreboot.org/#/c/31774/2/src/mainboard/emulation/qemu-power8/... File src/mainboard/emulation/qemu-power8/bootblock.c:
https://review.coreboot.org/#/c/31774/2/src/mainboard/emulation/qemu-power8/... PS2, Line 25: if (CONFIG(BOOTBLOCK_CONSOLE)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31774/2/src/mainboard/google/gru/chromeos.c File src/mainboard/google/gru/chromeos.c:
https://review.coreboot.org/#/c/31774/2/src/mainboard/google/gru/chromeos.c@... PS2, Line 39: #if CONFIG(GRU_BASEBOARD_SCARLET) braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31774/2/src/mainboard/google/gru/chromeos.c@... PS2, Line 46: #if CONFIG(GRU_HAS_TPM2) braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31774/2/src/mainboard/google/jecht/smihandle... File src/mainboard/google/jecht/smihandler.c:
https://review.coreboot.org/#/c/31774/2/src/mainboard/google/jecht/smihandle... PS2, Line 62: if (CONFIG(BOARD_GOOGLE_TIDUS)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31774/2/src/mainboard/pcengines/apu2/romstag... File src/mainboard/pcengines/apu2/romstage.c:
https://review.coreboot.org/#/c/31774/2/src/mainboard/pcengines/apu2/romstag... PS2, Line 146: if (CONFIG(BOARD_PCENGINES_APU5)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31774/2/src/northbridge/intel/haswell/gma.c File src/northbridge/intel/haswell/gma.c:
https://review.coreboot.org/#/c/31774/2/src/northbridge/intel/haswell/gma.c@... PS2, Line 243: if (CONFIG(MAINBOARD_DO_NATIVE_VGA_INIT)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31774/2/src/soc/intel/cannonlake/acpi.c File src/soc/intel/cannonlake/acpi.c:
https://review.coreboot.org/#/c/31774/2/src/soc/intel/cannonlake/acpi.c@207 PS2, Line 207: if (CONFIG(CONSOLE_CBMEM)) suspect code indent for conditional statements (8, 8)
https://review.coreboot.org/#/c/31774/2/src/soc/intel/quark/storage_test.c File src/soc/intel/quark/storage_test.c:
https://review.coreboot.org/#/c/31774/2/src/soc/intel/quark/storage_test.c@1... PS2, Line 136: if (CONFIG(STORAGE_LOG)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31774/2/src/soc/intel/skylake/gpio.c File src/soc/intel/skylake/gpio.c:
https://review.coreboot.org/#/c/31774/2/src/soc/intel/skylake/gpio.c@162 PS2, Line 162: #if CONFIG(SKYLAKE_SOC_PCH_H) braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31774/2/src/southbridge/amd/sb700/sm.c File src/southbridge/amd/sb700/sm.c:
https://review.coreboot.org/#/c/31774/2/src/southbridge/amd/sb700/sm.c@308 PS2, Line 308: if (CONFIG(ENABLE_APIC_EXT_ID)) suspect code indent for conditional statements (8, 8)