Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47786 )
Change subject: soc/mediatek/mt8192: Init SSPM
......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47786/15/src/soc/mediatek/mt8192/Ma...
File src/soc/mediatek/mt8192/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/47786/15/src/soc/mediatek/mt8192/Ma...
PS15, Line 60: $(CONFIG_SPM_FIRMWARE) \
: $(CONFIG_SSPM_FIRMWARE)
nit: I don't think it's very important to do file name sorting here, so it is fine to add SSPM before SPM (so not changing two lines).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47786
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia834852af50e9e7e1b1222ed1e2be20e43139c62
Gerrit-Change-Number: 47786
Gerrit-PatchSet: 15
Gerrit-Owner: tinghan shen
tinghan.shen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 08 Dec 2020 09:16:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment