Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32112 )
Change subject: vboot: Change oprom checks to CONFIG_VBOOT, assert OPROM_MATTERS
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/32112/3/src/lib/bootmode.c
File src/lib/bootmode.c:
https://review.coreboot.org/#/c/32112/3/src/lib/bootmode.c@38
PS3, Line 38: Chrome OS
vboot
https://review.coreboot.org/#/c/32112/3/src/lib/bootmode.c@42
PS3, Line 42: dead_code
No strong opinion here in any way, but that name is confusing me in this context. it's more like "break_build()" ;-)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32112
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d6421509bdcdaa61b78015af3fa6241fe75bb7f
Gerrit-Change-Number: 32112
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Mon, 01 Apr 2019 08:01:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment