Thejaswani Putta has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36654 )
Change subject: libpayload: keyboard: Ignore special keys ......................................................................
Patch Set 10:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36654/6/payloads/libpayload/drivers... File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/c/coreboot/+/36654/6/payloads/libpayload/drivers... PS6, Line 235: media_key_mapping = mapping;
how about use the call back function? If we use array, this will contain most "0". […]
Done
https://review.coreboot.org/c/coreboot/+/36654/6/payloads/libpayload/drivers... PS6, Line 248: if (ch == 0xe0) {
change 0xe0 to MEDIA_KEY_PREFIX or something like this?
Done
https://review.coreboot.org/c/coreboot/+/36654/8/payloads/libpayload/drivers... File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/c/coreboot/+/36654/8/payloads/libpayload/drivers... PS8, Line 46: int (*media_key_mapping_callback)(char);
function definition argument 'char' should also have an identifier name
Done
https://review.coreboot.org/c/coreboot/+/36654/9/payloads/libpayload/drivers... File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/c/coreboot/+/36654/9/payloads/libpayload/drivers... PS9, Line 46: int (*media_key_mapping_callback)(char);
function definition argument 'char' should also have an identifier name
Done