Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46683 )
Change subject: nb/intel/haswell/early_init.c: Remove invalid register writes ......................................................................
Patch Set 5:
(1 comment)
Patch Set 4: Code-Review-1
I would like to talk about this before it goes in... For instance, it's possible that the bit in SSKPD gives the MRC a hint what to do. Also, reserved often just means "reserved from your eyes".
Sighting 366252 first appeared in sandybridge, and the code was copy-pasted from Haswell.
https://review.coreboot.org/c/coreboot/+/46683/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46683/4//COMMIT_MSG@9 PS4, Line 9: 0x6120
It does not appear anywhere in reference code, and was dropped from Broadwell in CL:199364
I've updated the commit message.