Attention is currently required from: Tarun Tuli, Michał Żygowski, Subrata Banik.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69510 )
Change subject: soc/intel/alderlake/acpi.c: Don't look up coreboot CPU index
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
I mean it doesn't make any difference with and without the patch applied.
Right. Looking at the code:
loop over struct dev
loop over i
if( dev->apic_id == cpu_get_apic_id(i)
...
is really the same as
loop over i as filling in the apicid happens based on which CPU gets the index spinlock first.
So this patch is just a cleaner way of writing the same.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69510
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaaaef213b32b33e3ec9f4874d576896c2335211c
Gerrit-Change-Number: 69510
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Comment-Date: Tue, 29 Nov 2022 12:00:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment