Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33055 )
Change subject: soc/sifive/fu540: add code for spi and map flash to memory spaces
......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33055/9/src/mainboard/sifive/hifive...
File src/mainboard/sifive/hifive-unleashed/media.c:
https://review.coreboot.org/c/coreboot/+/33055/9/src/mainboard/sifive/hifive...
PS9, Line 40: void boot_device_init(void)
MSEL is only used to determine where ZSBL and FSBL (coreboot) are. […]
Done
https://review.coreboot.org/c/coreboot/+/33055/9/src/mainboard/sifive/hifive...
PS9, Line 42: const static uint8_t reset_en = 0x66;
This is not to initialize the spi flash, here is to tell the fu540 spi controller how to read the fl […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33055
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I106688c65ac7dd70be7479dc4691797b700682d9
Gerrit-Change-Number: 33055
Gerrit-PatchSet: 14
Gerrit-Owner: Xiang Wang
merle@hardenedlinux.org
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Xiang Wang
merle@hardenedlinux.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 08 Aug 2019 07:25:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Xiang Wang
merle@hardenedlinux.org
Gerrit-MessageType: comment