Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32869 )
Change subject: device_tree: Add overlay support
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/32869/5/src/lib/device_tree.c
File src/lib/device_tree.c:
https://review.coreboot.org/#/c/32869/5/src/lib/device_tree.c@1450
PS5, Line 1450: static const char *overlay_path[] = { "__overlay__", NULL };
static const char * array should probably be static const char * const
This is a false positive btw, in case anyone is waiting for me to fix that. dt_find_node_by_path() takes a const char **, not a const char * const *.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32869
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibec833cd471201bcc7a79eebf360d5f12adb8ff9
Gerrit-Change-Number: 32869
Gerrit-PatchSet: 5
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 04 Jun 2019 20:06:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment